fix: return 404 for non-existing revisions#6014
Merged
rjsparks merged 5 commits intoietf-tools:mainfrom Jul 23, 2023
Merged
Conversation
Links to non-existing revisions to docs should return 404
Codecov Report
@@ Coverage Diff @@
## main #6014 +/- ##
==========================================
- Coverage 88.67% 88.64% -0.03%
==========================================
Files 288 288
Lines 40001 40010 +9
==========================================
- Hits 35471 35467 -4
- Misses 4530 4543 +13
|
jennifer-richards
requested changes
Jul 23, 2023
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Looks good, but I think one small addition is needed. See inline comment.
Contributor
Author
|
Feel free to squash before merging to simplify history if needed 😅 |
Member
:-) that's our usual practice, otherwise our history would be more, uh, "interesting." |
jennifer-richards
approved these changes
Jul 23, 2023
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Looks good. Your last change, I think, restores the behavior of returning the current bibtex for a request for a (non RFC) draft with a nonexistent revision. That seems fine to me.
rjsparks
approved these changes
Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to non-existing revisions to docs should return 404
Closes #5934